feat(ws): add validation webhooks for Workspace and WorkspaceKind #34
Conversation
Signed-off-by: Adem Baccara <[email protected]>
Signed-off-by: Adem Baccara <[email protected]>
Signed-off-by: Adem Baccara <[email protected]>
… webhook Signed-off-by: Adem Baccara <[email protected]>
|
@thesuperzapper I've added a commit to refactor the |
Signed-off-by: Adem Baccara <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
|
@Adembc thanks for your work on this and the rest of GSOC! I did quite a bit of refactoring in the following commits: The WorkspaceKind webhook needed a lot of work to make it behave correctly (and detect redirect cycles in a semi-efficient way), and I also made the tests specifically check for each kind of error and added some "success" cases, because otherwise everything might just be failing. I think this PR should be ready for an initial merge now, there should only be two things left to have a fully working controller, I will raise issues so we can track that work publicly:
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR makes the following changes:
Workspace Validations:
spec.kind(must reference an existing WorkspaceKind).WorkspaceKind Validations:
spec.podTemplate.options.imageConfig.values[].specspec.podTemplate.options.podConfig.values[].specspec.podTemplate.options.imageConfig.values[].spec.ports[].portare unique.spec.podTemplate.extraEnv[].valueis a valid Go template.Tests: